-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Py: Complete implementation of mpz_ and or xor for negative arguments #1810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
dbd852d
Complete implementation of mpz_ and or xor for negative arguments
dcurrie f7cdb8f
py: code size optimizations in mpz and_neg or_neg xor_neg
dcurrie 14b46e2
py: save a few more __text bytes in mpz_neg_and_or_xor
dcurrie 30b3cb7
py: fix comments in py/mpz.c per code review
dcurrie 3ea800d
py: compile time option MICROPY_MPZ_BITWISE_SPEEDIER for benchmarking
dcurrie 5ce8baa
Merge branch 'master' into mpz_neg_and_or_xor
dcurrie 233e47c
py: rename MICROPY_MPZ_BITWISE_SPEEDIER to MICROPY_MPZ_BITWISE_FAST
dcurrie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not good. DIG_SIZE is usually the number of bits in mpz_dig_t (eg 16, uint16_t) and so this shift is undefined by the C standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
carryk
is ampz_dbl_dig_t
as are all thecarryX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes, correct! I was looking at the type of the masks....