fix make -C mpy-cross on arm #2848
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhylands
added a commit
to dhylands/micropython
that referenced
this pull request
Feb 7, 2017
It seems that the gcc toolchain on the RaspberryPi likes %progbits instead of @progbits. I verified that %progbits also works under x86, so this should fix micropython#2848 and fix micropython#2842 I verified that unix and mpy-cross both compile on my RaspberryPi and on my x64 machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the @ in this line is being interpreted as a comment. Checking if arch is arm and replacing @ with % makes this build properly. I don't know if the stack is being marked no execute as intended however.
.section .note.GNU-stack,"",@progbits
bryan@chip0:~/Source/micropython$ make -C mpy-cross
make: Entering directory '/home/bryan/Source/micropython/mpy-cross'
Use make V=1 or set BUILD_VERBOSE in your environment to increase build verbosity.
Generating build/genhdr/mpversion.h
CC ../py/nlrx86.S
../py/nlrx86.S: Assembler messages:
../py/nlrx86.S:194: Error: junk at end of line, first unrecognized character is `,'
../py/mkrules.mk:25: recipe for target 'build/py/nlrx86.o' failed
make: *** [build/py/nlrx86.o] Error 1
make: Leaving directory '/home/bryan/Source/micropython/mpy-cross'
There is likely a cleaner way to make this change but this is what I came up with.