Correct compiler error (unused static) if no I2C ports defined by port #3504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I took your hint about removing all I2C code and applied it in c73360b. So now if a board doesn't define any I2C ports then none of the hardware I2C code is included, and the pyb.I2C class is removed (since it can no longer function). |
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Oct 13, 2020
Fixes micropython#3504 hopefully.
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Feb 9, 2021
The time.sleep() and time.monotonic() functions break the timer interrupt on which PewPew10 display relies, so we can't use them anymore. Instead I'm adding a time-keeping function to the display code itself, which then can be used in pew.tick() internally.
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Feb 9, 2021
Fix micropython#3504: Don't use time module in pew.tick()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this patch is a good idea, but I needed to be able to build on my board with no I2C bus.
I would prefer to remove all the I2C code using a single define, but there wasn't such a define ready to go, and that change would impact more files.