extmod/modframebuf: add XRGB8888 format #4880
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a 32-bit per pixel XRGB format to the framebuf module. This format is seen in some Linux display drivers.
|
Like RGB565, I think this should be explicit about the byte order otherwise the behaviour will change between BE and LE CPUs (see #3536). |
|
I'd question whether 32-bit modes are relevant to any microcontroller port for these reasons:
|
|
Most if not all displays support partial screen updates, so one could argue you don't need the full screen dimensions @ 32 bit represented in your framebuf - eg. you could be drawing a collection of sprites. |
|
In addition to partial updates, I think this is a worthwhile feature for, e.g. APA102 and RGBW WS2812 LED strips. See #7253 for discussion. |
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Jun 23, 2021
Esp32s2: implement ParallelImageCapture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a 32-bit per pixel XRGB format to the framebuf module.
This format is seen in some Linux display drivers.