Skip to content

Allow the uPy used by run-tests to be overridden #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2014

Conversation

lurch
Copy link
Contributor

@lurch lurch commented Apr 16, 2014

with MICROPY_MICROPYTHON envvar, in an analogous way to MICROPY_CPYTHON3 envvar.

(the reason for this will be made clearer by a later PR)

with MICROPY_MP_PY envvar, in an analogous way to MICROPY_CPYTHON3 envvar.

(the reason for this will be made clearer by a later PR)
lurch added a commit to lurch/micropython that referenced this pull request Apr 16, 2014
In conjunction with micropython#504 this allows you to do things like:
```shell
make -C unix clean && make -C unix test CC=gcc-4.7
```
all from the top-level micropython directory :-)

Something similar could probably be done for windows/Makefile too, but I don't have a cygwin setup to test with.
@pfalcon
Copy link
Contributor

pfalcon commented Apr 16, 2014

What's MICROPY_MP_PY supposed to mean? ;-)

@lurch
Copy link
Contributor Author

lurch commented Apr 16, 2014

I dunno, I was just keeping "in sync" with the name of the variable already used in the code...

Better suggestions willingly accepted ;-)

@lurch
Copy link
Contributor Author

lurch commented Apr 16, 2014

...hmmm, IMHO this build failure makes no sense - I get the identical error on my local machine if I delete unix/micropython before running the tests, and yet according to that build log unix/micropython should have built just fine?

Possibly a glitch?! @pfalcon or @dpgeorge could you try restarting it for me please?

@pfalcon
Copy link
Contributor

pfalcon commented Apr 16, 2014

Yeah, but can you please de-acronymize it? Is it "micropython mycropython python"? Random suggestion is "MICROPY_MICROPY", or if that's confusing, use MICROPY_MICROPY_EXE and MICROPY_CPYTHON3_EXE.

@pfalcon
Copy link
Contributor

pfalcon commented Apr 16, 2014

Well, the error is "TypeError: expect bytes or str, not tuple", can you comment on that?

@pfalcon
Copy link
Contributor

pfalcon commented Apr 16, 2014

restarted.

@lurch
Copy link
Contributor Author

lurch commented Apr 16, 2014

I'd be happy with MICROPY_MICROPYTHON (as micropython is the default binary name) but let's see what @dpgeorge says.

@dpgeorge
Copy link
Member

MICROPY_MICROPYTHON sounds best to me.

lurch added a commit to lurch/micropython that referenced this pull request Apr 17, 2014
@lurch
Copy link
Contributor Author

lurch commented Apr 17, 2014

Great - updated #504 and #505 to use MICROPY_MICROPYTHON

dpgeorge added a commit that referenced this pull request Apr 17, 2014
Allow the uPy used by run-tests to be overridden
@dpgeorge dpgeorge merged commit 91d0ab9 into micropython:master Apr 17, 2014
@lurch lurch deleted the patch-4 branch April 17, 2014 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy