extmod/modbluetooth: Persist reference to NimBLE service instances. #5240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NimBLE doesn't actually copy this data, it requires it to stay live. Only dereference when we register a new set of services. Fixes micropython#5226 This will allow incrementally adding services in the future, so rename `reset` to `append` to make it clearer.
This allows the maximum size of a characteristic/descriptor to be increased by locally writing to it first.
|
Great, thank you! |
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NimBLE doesn't actually copy this data, it requires it to stay live.
Only dereference when we register a new set of services.
Fixes #5226
This will allow incrementally adding services in the future, so
rename
resettoappendto make it clearer.Also fix a truncation with chars/descs that have been increased
from the default size.