Skip to content

pathlib: Fix glob() to return Path objects rather than strings. #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

RotatingLlama
Copy link

Fix glob() to return Path objects rather than bare strings, same as CPython https://docs.python.org/3/library/pathlib.html#pathlib.Path.glob

@andrewleech
Copy link
Contributor

This discrepancy with cpython caught me out recently too, thanks for submitting the fix.

Would you be able to update the commit message to match the repo standard needs patterns and force-push to the same branch? That would fix the ci failure.

@RotatingLlama
Copy link
Author

No probs, it's very minor. This is actually my first pull request and I spent about half an hour yesterday trying to fix the error, but couldn't figure out how to do it. Would you give me a pointer, please?

@RotatingLlama RotatingLlama marked this pull request as draft July 17, 2025 19:40
@RotatingLlama RotatingLlama changed the title pathlib: Fix glob() to return Path objects rather than strings pathlib: Fix glob() to return Path objects rather than strings. Jul 17, 2025
@RotatingLlama
Copy link
Author

I've now spent literal hours of my life trying to understand how to fix this pull request, and am still no further forward. I'm not willing to waste any more time for the sake of such a minor correction. I'm going to see if I can delete it for the sake of keeping the place tidy, but if it won't let me do that either then I'm out.

@RotatingLlama RotatingLlama deleted the patch-1 branch July 17, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy