test: fix client-certificate tests #36734
Merged
+464
−462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Jul 21, 2025
| @@ -0,0 +1,86 @@ | |||
| # Client Certificate test-certificates | |||
|
|
|||
There was a problem hiding this comment.
Let's add a description to the test file that uses the certificates on when and how the certificates should be regenerated. Or maybe keep the readme and put a short description in it.
Test results for "tests 1"9 flaky46758 passed, 926 skipped Merge workflow run. |
yury-s
pushed a commit
that referenced
this pull request
Jul 21, 2025
This was referenced Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We internally use
TLSSocket.authorizedto check if a client's certificate is valid. If its expired, its not valid anymore. This PR moves the commands from theREADME.mdto thegenerate.shand sets the lifetime to 10y.This fixes tests:
npm run ctest client-certificatesbecause the certs were expired.