fix: setup.py --all only put local driver if arch matches #1043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e989d70 to
15c5ee5
Compare
kumaraditya303
approved these changes
Nov 19, 2021
95797c5 to
3bdd616
Compare
kumaraditya303
suggested changes
Nov 19, 2021
e55d044 to
aecb1e2
Compare
af554e7 to
2be58f1
Compare
2be58f1 to
08ef2d4
Compare
pavelfeldman
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this CL if you have used setup.py -all it resulted in that the local driver got overridden by the last matching downloaded driver. Only Linux or MacOS this would be then the wrong architecture in most cases.
drive-by: had to rename it a bit, because it conflicted otherwise with the imported platform module.