test: add test for Command + C does not terminate driver connection #1908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue what this solves is that by default if a user presses Command + C it will send it to the
main.py
script (good) but also to thedriver
(bad) which will instantly close the browsers etc. This is because the driver is getting launched as the same process group, we should launch it as a separate process group imo.See https://unix.stackexchange.com/a/149756
Since upstream we can do the following:
we should be able to do the same in Python. It should be an implementation detail that we are launching a subprocess internally.
#1843