feat(roll): roll Playwright to 1.13.0-next-1625813701000 #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Jul 9, 2021
|
The bots are unhappy |
e5a24a8 to
92b178a
Compare
|
|
||
|
|
||
| async def test_download_cancel_should_work(browser, server): | ||
| def handle_download(request): |
There was a problem hiding this comment.
Consider using context managers in new test code
There was a problem hiding this comment.
I want to keep the tests similar to upstream tests, so its easier to work with them in the future.
3 tasks
b993ec1 to
fe040b9
Compare
fe040b9 to
cc520ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.