feat(roll): roll Playwright 1.15.0-next-1631091227000 #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mxschmitt merged 5 commits into microsoft:master from mxschmitt:wait-for-selector

Sep 10, 2021

Member

mxschmitt commented Sep 2, 2021

microsoft/playwright#8632


          chore: add wait_for_selector{hidden,visible}

d019108

mxschmitt force-pushed the wait-for-selector branch from edb5578 to d019108 Compare

September 7, 2021 21:36

mxschmitt changed the title ~~chore: add wait_for_selector{hidden,visible}~~ feat(roll): roll Playwright 1.15.0-next-1631091227000

mxschmitt marked this pull request as ready for review

September 8, 2021 10:21

mxschmitt force-pushed the wait-for-selector branch 2 times, most recently from b54636c to d9e84ef Compare

September 8, 2021 10:59

kumaraditya303 reviewed

View reviewed changes

playwright/_impl/_element_handle.py Outdated Show resolved Hide resolved

kumaraditya303 reviewed

View reviewed changes

playwright/_impl/_frame.py Outdated Show resolved Hide resolved

kumaraditya303 reviewed

View reviewed changes

playwright/_impl/_network.py Outdated Show resolved Hide resolved

kumaraditya303 reviewed

View reviewed changes

playwright/_impl/_tracing.py Outdated Show resolved Hide resolved

kumaraditya303 reviewed

View reviewed changes

playwright/_impl/_tracing.py Outdated Show resolved Hide resolved

kumaraditya303 reviewed

View reviewed changes

tests/async/test_network.py

		FOO_URL = server.PREFIX + "/foo.html"
		events = {}

Contributor

kumaraditya303 Sep 8, 2021

Better to use defaultdict here


          feat(roll): roll Playwright 1.15.0-next-1631091227000

ebfd282

mxschmitt force-pushed the wait-for-selector branch from d9e84ef to ebfd282 Compare

September 8, 2021 11:22

kumaraditya303 reviewed

View reviewed changes

playwright/_impl/_network.py Show resolved Hide resolved

kumaraditya303 reviewed

View reviewed changes

tests/async/test_network.py Outdated Show resolved Hide resolved

kumaraditya303 reviewed

View reviewed changes

tests/async/test_network.py Show resolved Hide resolved


          roll the dice

5ec58d1

mxschmitt force-pushed the wait-for-selector branch from 9516d8d to 5ec58d1 Compare

September 9, 2021 17:49

mxschmitt added 2 commits

September 10, 2021 11:24

go

ccc01e1


          test

51f85b2

mxschmitt force-pushed the wait-for-selector branch from 46c1e86 to 51f85b2 Compare

September 10, 2021 10:19

mxschmitt merged commit 89b957b into microsoft:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy