Skip to content

fix: Fixed freezed class typo #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 5, 2024
Merged

fix: Fixed freezed class typo #135

merged 3 commits into from
Jan 5, 2024

Conversation

utpal-barman
Copy link
Collaborator

@utpal-barman utpal-barman commented Dec 6, 2023 •
edited
Loading

General

  • Fixed a typo for a freezed class which was making an error on the build runner
  • Did a run on an iOS simulator which migrated IPHONEOS_DEPLOYMENT_TARGET to 11.0 automatically
  • After splash screen it was navigating (pushing) to the screen, but should replace the splash screen
  • super.initState() moved on the top of the overridden initState method

Pull Request (PR) Checklist

  • PR title includes Jira ticket reference -- if no ticket available create one if this PR is a fix or feat
  • Branch name includes Jira ticket reference (parent ticket and sub-task if available), e.g. 'feat/APP-XXX_Some_Feature' or feat/APP-XXX_APP-XXX_Some_Sub_Task or 'fix/APP-XXX_Some_Fix' or 'refactor/Some_Refactoring'
  • All PR checks pass and changes under /domain are covered with unit tests
  • Jira ticket provides testing infos for QA -- add a comment if needed e.q. for pre-requisites, order of API calls, ...
  • When merging this PR the commit message follows conventional-commits, e.g. 'feat(some optional epic): add some feature (APP-XXX) (#XXX)'

@utpal-barman utpal-barman mentioned this pull request Dec 6, 2023
Merged
@utpal-barman
Copy link
Collaborator Author

as I changed the minimum deployment target and os version to 12.0, requesting for approval again

hassan-saleh-ml
hassan-saleh-ml approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@hassan-saleh-ml hassan-saleh-ml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also change some Android stuff like gradle and kotlin versions?

@utpal-barman
Copy link
Collaborator Author

Good point, let me check the android one as well

@utpal-barman
Copy link
Collaborator Author

utpal-barman commented Jan 4, 2024 •
edited
Loading

@hassan-saleh-ml
I tried to upgrade the version (suggested by flutter create .) but it looks like Nstack is complaining

* What went wrong:
The Android Gradle plugin supports only Kotlin Gradle plugin version 1.5.20 and higher.
The following dependencies do not satisfy the required version:
project ':nstack' -> org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.50

so we need this PR to be merged https://github.com/nstack-io/flutter-sdk/pull/57/files

I prefer to keep the current Gradle version as it is for now in this template, later we can do this in a separate PR

@nivisi
Copy link
Contributor

nivisi commented Jan 5, 2024

Agree. Let's do this in a separate PR. We should have updated the iOS stuff separately as well 😄

@nivisi nivisi merged commit 401507c into master Jan 5, 2024
@nivisi nivisi deleted the fix/freezed-typo branch January 5, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivisi nivisi nivisi approved these changes

@hassan-saleh-ml hassan-saleh-ml hassan-saleh-ml approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@utpal-barman @nivisi @hassan-saleh-ml
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy