Skip to content

feat: Added PR Template #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2024
Merged

feat: Added PR Template #136

merged 1 commit into from
Jan 10, 2024

Conversation

utpal-barman
Copy link
Collaborator

@utpal-barman utpal-barman commented Jan 8, 2024 •
edited
Loading

Pull Request (PR) Checklist

  • PR title includes Jira ticket reference -- if no ticket available create one if this PR is a fix or feat
  • Branch name includes Jira ticket reference (parent ticket and sub-task if available), e.g. 'feat/APP-XXX_Some_Feature' or feat/APP-XXX_APP-XXX_Some_Sub_Task or 'fix/APP-XXX_Some_Fix' or 'refactor/Some_Refactoring'
  • All PR checks pass and changes under /domain are covered with unit tests
  • Jira ticket provides testing infos for QA -- add a comment if needed e.q. for pre-requisites, order of API calls, ...
  • When merging this PR the commit message follows conventional-commits, e.g. 'feat(some optional epic): add some feature (APP-XXX) (#XXX)'

Related to other PRs

Notes for PR reviewers

nivisi
nivisi approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@nivisi nivisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@utpal-barman utpal-barman merged commit 739fad0 into ml-opensource:master Jan 10, 2024
@utpal-barman utpal-barman deleted the feat/pr-template branch January 10, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivisi nivisi nivisi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utpal-barman @nivisi
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy