Skip to content

feat: Integrated theme tailor #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

utpal-barman
Copy link
Collaborator

@utpal-barman utpal-barman commented Feb 6, 2024

General

  • Converted Theme Extensions with theme_tailor package to generate .copyWith() and .lerp() method automatically in the generated mixin.

  • As the theme won't be changed too frequently, kept the generated .tailor file in the repo, it will help to build the generation quickly

[I'm ambitious about the macro things, maybe we can migrate once it's in the stable version and we can remove this tailor thing]

Checklists

  • Platform specific changes (input, image picking etc) are tested on both of the platforms (Android and iOS)
  • It is tested that the UI changes are rendered correctly on different device sizes (such as long lists or expanded rows) with safe area conditions.
  • Edge cases, such as responses being empty or invalid, missing data, no internet connection etc, are tested and the app works as expected.

Showcase

  • Either showcase screenshots / videos are attached, or this PR does not require such any showcase.

@utpal-barman utpal-barman merged commit 7fc463b into ml-opensource:master Feb 7, 2024
@utpal-barman utpal-barman deleted the feat/theme-tailor-integration branch February 7, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy