Skip to content

chore: Migrated to android gradle plugin #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

utpal-barman
Copy link
Collaborator

@utpal-barman utpal-barman commented Apr 18, 2024

General

Currently while running on the Android app, it's showing a message on the console to migrate to the Android Gradle Plugin block instead of the deprecated apply script method

You are applying Flutter's app_plugin_loader Gradle plugin imperatively using the apply script method, which is deprecated and will be removed in a future release. Migrate to applying Gradle plugins with the declarative plugins block: https://flutter.dev/go/flutter-gradle-plugin-apply

You are applying Flutter's main Gradle plugin imperatively using the apply script method, which is deprecated and will be removed in a future release. Migrate to applying Gradle plugins with the declarative plugins block: https://flutter.dev/go/flutter-gradle-plugin-apply

Additionally The latest Flutter 3.19.5 • channel stable — suggests using the newer version of the Gradle version.

To migrate into the Gradle plugins with the declarative plugins block, android platform codes were regenerated by running the flutter create . platforms=android, so gradle versions were replaced by the latest flutter version.

⚠️ Blocker and Solution

Currently, there is a blocker to migrate this task, nstack plugin is using an old gradle version without a namespace field in android block, though it was overridden to overcome this issue

Checklists

  • Platform specific changes (input, image picking etc) are tested on both of the platforms (Android and iOS)
  • It is tested that the UI changes are rendered correctly on different device sizes (such as long lists or expanded rows) with safe area conditions.
  • Edge cases, such as responses being empty or invalid, missing data, no internet connection etc, are tested and the app works as expected.

Showcase

  • Either showcase screenshots / videos are attached, or this PR does not require such any showcase.

@nivisi
Copy link
Contributor

nivisi commented Apr 23, 2024

Great call @utpal-barman. Regarding NStack, I think we should plan something for Pritam to perform the migration.

@hassan-saleh-ml
Copy link
Contributor

@utpal-barman did you try to build an apk after these changes?

@utpal-barman
Copy link
Collaborator Author

utpal-barman commented Apr 23, 2024

@hassan-saleh-ml
Yes I tried to build

To make sure again just tried now on this branch —

Screenshot 2024-04-23 at 4 05 42 PM

@nivisi Yes, updating NStack is a must now, I can see Hassan already opened a draft PR there nstack-io/flutter-sdk#57

@utpal-barman utpal-barman force-pushed the chore/update-android-gradle branch from bc426c5 to 12c0434 Compare May 15, 2024 19:28
@utpal-barman utpal-barman merged commit 540a327 into ml-opensource:master Oct 4, 2024
1 check passed
@utpal-barman utpal-barman deleted the chore/update-android-gradle branch October 4, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy