First of all, welcome!
The idea is pretty cool. Could we add a position to sort statistics providers?

https://symfony.com/blog/new-in-symfony-4-3-indexed-and-tagged-service-collections

Hi @loic425 ,

Thank you!

And that's a good idea! I just did a test with your proposed solution, but I don't think this could be used to add a sort to the statistics. Because if I want to use a int as the key for sorting, the compilerpass overwrites it with the default array keys. This solution only works when defining your keys as words. Which would require extra code to convert those to values.

I propose to use the native supported functionality to add a priority to the service.
https://symfony.com/doc/current/service_container/tags.html#reference-tagged-services (at the bottom of the page). This way you can sort the statistics by giving them a higher or lower priority?

I propose to use the native supported functionality to add a priority to the service.
https://symfony.com/doc/current/service_container/tags.html#reference-tagged-services (at the bottom of the page). This way you can sort the statistics by giving them a higher or lower priority?

Yes you're right. It's a good solution:)

@lucasballyn The build has failed.

etc/travis/suites/application/script/validate-yaml-files
replace run_command "bin/console lint:yaml config"
with run_command "bin/console lint:yaml config --parse-tags"

Do you know phpspec ? there are few errors.
If you want, I can fix this part.

Unfortunately I don't know phpspec :( But I wouldn't mind learning if it's necessary to contribute to oss? Maybe (if you have time) you could do it for this PR, and in meantime I start learning it?

Is that ok for you?

Thanks in advance!

Unfortunately I don't know phpspec :( But I wouldn't mind learning if it's necessary to contribute to oss? Maybe (if you have time) you could do it for this PR, and in meantime I start learning it?

Is that ok for you?

Thanks in advance!

Deal!
lf you plan to contribute on Sylius and Monofony, yes it's necessary. I discovered it when contributing on Sylius and it's so cool to design your services (and improve/refactor it later).

Unfortunately I don't know phpspec :( But I wouldn't mind learning if it's necessary to contribute to oss? Maybe (if you have time) you could do it for this PR, and in meantime I start learning it?
Is that ok for you?
Thanks in advance!

Deal!
lf you plan to contribute on Sylius and Monofony, yes it's necessary. I discovered it when contributing on Sylius and it's so cool to design your services (and improve/refactor it later).

Ok! Thank you very much!

@lchrusciel Can you make a review please. This seems to me interesting but I'd like to have your opinion.

@lucasballyn @lchrusciel
In Symfony 4.4 we can use a priority method to sort services!
symfony/symfony#33628

Perfect for this PR!

Hi @loic425,

Thank you for the updates while I was a little inactive! I hope to have more time soon to contribute more actively!

Anything else I need to do for this PR? Or is this ready to merge?

Thanks in advance!

@lucasballyn Adding a cookbook on documentation seems to be necessary.
if you have enough time, you can init this new cookbook chapter. As you can see, there's a "getDefaultPriority" to sort the statistics but you need to clear cache to apply new sorting.

Thank you @lucasballyn! 🎉