Skip to content

Bump postcss-loader to v2.1.1 from v2.1.2 #4591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 19, 2018
Merged

Bump postcss-loader to v2.1.1 from v2.1.2 #4591

merged 3 commits into from
Mar 19, 2018

Conversation

b4handjr
Copy link
Contributor

The docker image is being built with a postcss-loader version that has been updated with a breaking change. This pins the version to a known working state until we can investigate further.

@b4handjr b4handjr self-assigned this Mar 19, 2018
@b4handjr b4handjr requested a review from kumar303 March 19, 2018 20:42
This was referenced May 5, 2024
Closed
Closed
kumar303
kumar303 approved these changes Mar 19, 2018
View reviewed changes
Copy link
Contributor

@kumar303 kumar303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Make sure the issue about fixing this mentions putting the tilde back in the version spec.

@b4handjr
Copy link
Contributor Author

I am getting this failure on travis:

Summary of all failing tests
FAIL tests/unit/TestPackageJson.js
  � Package JSON › should have devDependencies[postcss-loader] version prefixed with "^"

    expect(received).toEqual(expected)
    
    Expected value to equal:
      StringMatching /^(\^|git)/
    Received:
      "2.1.1"
      
      at Object.<anonymous> (tests/unit/TestPackageJson.js:27:50)

@b4handjr b4handjr requested a review from kumar303 March 19, 2018 21:18
kumar303
kumar303 approved these changes Mar 19, 2018
View reviewed changes
Copy link
Contributor

@kumar303 kumar303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ if the tests pass

tests/unit/TestPackageJson.js
const skipDevDeps = [];

// postcss-loader: https://github.com/mozilla/addons-frontend/issues/4592
const skipDevDeps = ['postcss-loader'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right, I forgot about that

@codecov-io
Copy link

codecov-io commented Mar 19, 2018 •
edited
Loading

Codecov Report

Merging #4591 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4591   +/-   ##
=======================================
  Coverage   95.46%   95.46%           
=======================================
  Files         203      203           
  Lines        4722     4722           
  Branches      963      963           
=======================================
  Hits         4508     4508           
  Misses        188      188           
  Partials       26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5475499...29e2619. Read the comment docs.

@b4handjr b4handjr merged commit 6b3a9e0 into mozilla:master Mar 19, 2018
@b4handjr b4handjr deleted the bump-postcss-loader-to-2.1.1 branch March 19, 2018 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumar303 kumar303 kumar303 approved these changes

Assignees

@b4handjr b4handjr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@b4handjr @codecov-io @kumar303
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy