-
Notifications
You must be signed in to change notification settings - Fork 18
Use updated gems and littlefs #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default mount path is "/storage" now
Fewer annoying build errors
Modified the 'mruby-fileio' gem so File#write auto seeks to EOF when in append mode, which littlefs was expecting it to handle. Shouldn't hurt other filesystems regardless
Fixed the append mode problem with a small change in the |
yuuu
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code is worked on ESP32-DevKitC that I have. I'll approve your pull request. Thank you 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings all the changes to dependency gems, outlined in #41, into the IDF project:
mruby-io
to match mruby 3.2.0File
class inmruby-fileio
, with examplemruby-socket
to match mruby 3.2.0 and work with IDF 5As well as:
mruby-esp32-ledc
gem in the project, with 3 examples#write
doesn't automatically move it to the end. Not sure what's going on here.Total image size comparison (ESP32, IDF 5.1):
master: 1370 kB
0.5 with gems matching master: 1382 kB
0.5 with all new gems and features (default): 1445 kB
0.5 with everything except
mruby-socket
: 1402 kB