Improve tracebacks #691
Merged
Improve tracebacks #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use "logical" function names in traceback rather than the "real" function name. (For example, in a nested function, use the function name instead of __call__.) * Omit glue and helper functions from tracebacks. (This is implemented by skipping tracebacks for functions that don't have a "logical" name.) Closes #428, #614.
ilevkivskyi
approved these changes
Aug 20, 2019
mypyc/ops.py
Outdated
| self.decl = decl | ||
| self.blocks = blocks | ||
| self.env = env | ||
| self.traceback_name = traceback_name |
There was a problem hiding this comment.
I know it may be a bit premature, but I would start adding doc comments for attributes (mostly for motivation).
mypyc/exceptions.py
Outdated
| @@ -86,7 +86,7 @@ def split_blocks_at_errors(blocks: List[BasicBlock], | |||
| op=variant, | |||
| line=op.line) | |||
| branch.negated = negated | |||
| if op.line != NO_TRACEBACK_LINE_NO: | |||
| if op.line != NO_TRACEBACK_LINE_NO and func: | |||
There was a problem hiding this comment.
May this cause troubles is a mypy bug will generate function with .fullname set to None (or an empty string)?
Also TBH I would rename this argument to func_name and write ... and func_name is not None.
| globals_static = emitter.static_name('globals', module_name) | ||
| traceback_code = 'CPy_AddTraceback("%s", "%s", %d, %s);' % ( | ||
| source_path.replace("\\", "\\\\"), | ||
| fn.traceback_name or fn.name, |
There was a problem hiding this comment.
Is it possible to move this logic to .name (which is a property)?
There was a problem hiding this comment.
I think I'd rather be explicit about it here. But I'll add a comment explaining why we are doing a traceback at all when there is no traceback_name, even though we don't in other cases.
msullivan
added a commit
to python/mypy
that referenced
this pull request
Aug 20, 2019
* Use "logical" function names in traceback rather than the "real" function name. (For example, in a nested function, use the function name instead of __call__.) * Omit glue and helper functions from tracebacks. (This is implemented by skipping tracebacks for functions that don't have a "logical" name.) Closes mypyc/mypyc#428, mypyc/mypyc#614.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
function name. (For example, in a nested function, use the function
name instead of
__call__.)implemented by skipping tracebacks for functions that don't have a
"logical" name.)
Closes #428
Closes #614