Update tab-view.md #226
Closed
Update tab-view.md #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for nativescript-vue ready! Built with commit a535d01 |
ikoevska
suggested changes
Nov 5, 2018
| @@ -35,7 +35,7 @@ contributors: [MisterBrownRSA, rigor789, eddyverbruggen, ikoevska, kharysharpe] | |||
| </TabViewItem> | |||
| </TabView> | |||
| ``` | |||
| **NOTE:** Use images for tab icons instead of icon fonts. | |||
| **NOTE:** Use images for tab icons instead of icon fonts. Because this is a native component, to control the size of the icons you should use resources as defined in https://github.com/nativescript-vue/nativescript-vue.org/blob/master/content/docs/en/elements/components/tab-view.md | |||
There was a problem hiding this comment.
This doesn't make any sense. You are referring to the page you're currently on (only to its source in GitHub). Is there a better link to use here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a reference to image resources for TabViewItem