Publishing plus immediate flush #1211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MauriceVanVeen
approved these changes
Aug 20, 2024
| * Flushes the underlying connection buffer the next chance it gets if the connection is valid. | ||
| * @throws IOException not applicable even though it's part of the signature due to implementation change | ||
| * Immediately flushes the underlying connection buffer if the connection is valid. | ||
| * @throws IOException the connection flush fails |
There was a problem hiding this comment.
*if the connection flush fails
| @@ -269,38 +269,41 @@ NatsMessage accumulate(long maxSize, long maxMessages, Duration timeout) | |||
| return null; | |||
| } | |||
|
|
|||
| NatsMessage msg = this.poll(timeout); | |||
| NatsPublishableMessage msg = (NatsPublishableMessage)this.poll(timeout); | |||
There was a problem hiding this comment.
Is this cast safe, poll(..) returns NatsMessage?
There was a problem hiding this comment.
I think so because of single reader mode but I will review
MauriceVanVeen
approved these changes
Aug 20, 2024
scottf
commented
Aug 26, 2024
| * Flushes the underlying connection buffer the next chance it gets if the connection is valid. | ||
| * @throws IOException not applicable even though it's part of the signature due to implementation change | ||
| * Immediately flushes the underlying connection buffer if the connection is valid. | ||
| * @throws IOException if the connection flush fails |
There was a problem hiding this comment.
This simply reverts the comments back to the original, correct comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a "request" was made, there were two pieces of code
called in succession
The intention was that on a request, we want to get the publish part of the request out over the socket quickly. But because operation 1 simply queues the message, the flush likely happens before the message even got moved to the socket
So instead of the 2 step process that was did not do what was intended, I added internally the ability to say "flush right after this publish"
It sets a flag on the message in the queue and when processing that message for the queue, when I see the flag, I flush
So instead of the 2 steps, I now do a publish and set the flag on that message.
This only affects "requests" which is what was originally intended. This does not affect publishing.