Skip to content

Feature: Support adding service endpoint after construction #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 17, 2025
Merged

Feature: Support adding service endpoint after construction #1274

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2de49e2
update_service_to_support_adding_dynamic_endpoint_after_service_const…
rexf Feb 12, 2025
80df3aa
revert format change & restrict empty list to InfoResponse
rexf Feb 13, 2025
6d61c64
revert format change & restrict empty list to InfoResponse
rexf Feb 13, 2025
6ab406c
revert format change & restrict empty list to InfoResponse
rexf Feb 13, 2025
111caff
revert format change & restrict empty list to InfoResponse
rexf Feb 13, 2025
ce4b848
adding comments for 2 discovery contexts
rexf Feb 13, 2025
56edd32
sync with infoResponsse, adding empty list
rexf Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert format change & restrict empty list to InfoResponse
  • Loading branch information
@rexf
rexf committed Feb 16, 2025
commit 6ab406c742f90b5eb65ef0b59d1eae2ed59d3915
4 changes: 1 addition & 3 deletions src/main/java/io/nats/service/InfoResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,7 @@ private InfoResponse(JsonValue jv) {
@Override
protected void subToJson(StringBuilder sb) {
JsonUtils.addField(sb, DESCRIPTION, description);
if (!endpoints.isEmpty()) {
JsonUtils.addJsons(sb, ENDPOINTS, endpoints, true);
}
JsonUtils.addJsons(sb, ENDPOINTS, endpoints, true);
}

/**
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy