Skip to content

Better workflow for leadership change while pull consuming. #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2025

Conversation

scottf
Copy link
Contributor

@scottf scottf commented May 12, 2025

also some api doc cleanup and added a constant.

@scottf scottf requested a review from MauriceVanVeen May 12, 2025 16:21
statMsg.equals(MESSAGE_SIZE_EXCEEDS_MAX_BYTES))
if (statMsg.equals(BATCH_COMPLETED)
|| statMsg.equals(LEADERSHIP_CHANGE)
|| statMsg.equals(MESSAGE_SIZE_EXCEEDS_MAX_BYTES))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved LEADERSHIP_CHANGE to STATUS_TERMINUS (for simplified pull consuming, terminus translates to the pull is done, will need a new one)

Copy link
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf scottf merged commit 090e75f into main May 12, 2025
5 checks passed
@scottf scottf deleted the leadership-change branch May 12, 2025 19:14
@scottf scottf changed the title Better workflow for leadership change while simplified consuming. Better workflow for leadership change while pull consuming. Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy