Skip to content

Create 0028-find-the-index-of-the-first-occurence-in-a-string #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

benmak11
Copy link
Contributor

@benmak11 benmak11 commented Mar 7, 2023

Important

Please make sure the file name is lowercase and a duplicate file does not already exist before merging.

@a93a
Copy link
Collaborator

a93a commented May 6, 2023

Hi! A file with a solution for this already exists, but your solution differs so we could add it too, to the file.

Could you edit the existing file and add your solution to it, and I can merge it.

You can separate the solutions like this:

// Solution ONE (you can write the type of yuor solution like "brute-force", "KMP", "Hashing" etc)
class Solution {
    public int strStr(String haystack, String needle) {
        //...
    }
}

// Solution TWO
class Solution {
    public int strStr(String haystack, String needle) {
        //...
    }
}

@benmak11
Copy link
Contributor Author

Hi! A file with a solution for this already exists, but your solution differs so we could add it too, to the file.

Could you edit the existing file and add your solution to it, and I can merge it.

You can separate the solutions like this:

// Solution ONE (you can write the type of yuor solution like "brute-force", "KMP", "Hashing" etc)
class Solution {
    public int strStr(String haystack, String needle) {
        //...
    }
}

// Solution TWO
class Solution {
    public int strStr(String haystack, String needle) {
        //...
    }
}

Sorry for the delay on this, I have been traveling. I updated the PR based on your recommendation. Please let me know if there's anything else that needs to be done

@benmak11
Copy link
Contributor Author

benmak11 commented Aug 8, 2023

@a93a sorry to bother you, but have you had a chance to review the changes applied?

@a93a a93a merged commit 3ca9bdc into neetcode-gh:main Aug 27, 2023
@a93a
Copy link
Collaborator

a93a commented Aug 27, 2023

@benmak11 my apologies for the very late reply, I must somehow missed your update, sorry for that. But it looks good, thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy