Create 0523-continuous-subarray-sum.js #2548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added solution for continuous-subarray-sum in JS.
aakhtar3
requested changes
Jun 30, 2023
| */ | ||
| var checkSubarraySum = function(arr, k) { | ||
| let sum = 0; | ||
| const remainderMap = new Map(); |
There was a problem hiding this comment.
Suggestion: Init Map with value
const map = new Map([ [key, value] ])There was a problem hiding this comment.
Initializing map as Suggested.
Initializing Map as suggested.
aakhtar3
requested changes
Jul 1, 2023
| if(i - remainderMap.get(sum%k) > 1) { | ||
| return true; | ||
| } | ||
| } else { |
There was a problem hiding this comment.
I don't know how it would be possible without the else case. But I have removed it and added an if stetment. I also removed the nested if condition. Please have a look. Let me know if I can do better :) Btw, I update the submission link in the initial comment. So we know the newly updated code is correct and submitting. If I forget to update the submission link please let me know.
Trimmed the code.
aakhtar3
requested changes
Jul 2, 2023
| var checkSubarraySum = function(arr, k) { | ||
| let sum = 0; | ||
| const remainderMap = new Map([ [0, -1] ]); | ||
| // remainderMap.set(0,-1); |
Removing old commented code.
aakhtar3
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added solution for continuous-subarray-sum in JS.
File(s) Added: 0523-continuous-subarray-sum.js
Language(s) Used: JavaScript
Submission URL: https://leetcode.com/problems/continuous-subarray-sum/submissions/983776897/