chore: mock API to test account id #5859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 6a7942a
|
eduardoboucas
previously approved these changes
Jul 10, 2023
| args: ['--country', 'DE'], | ||
| env: { | ||
| NETLIFY_API_URL: mockApi?.apiUrl, | ||
| NETLIFY_SITE_ID: 'foo', |
There was a problem hiding this comment.
nit: It would be nice to get mock values that are a bit closer to the real ones we use, but not a big deal.
sarahetter
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
In #5848, @jrwhitmer added a change to pass
account.idinto functions and Edge Functions. During pairing, we decided to skip tests since I didn't see how to implement that.Today I stumbled over
mockAPI, which we're using in the rest of the codebase to test API interaction. This PR adds a test for that to theaccount.idchange :)For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)