-
Notifications
You must be signed in to change notification settings - Fork 413
feat: load generated functions from Netlify Build #7408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d7c8699
feat: load generated functions from Netlify Build
eduardoboucas e575da7
Merge branch 'main' into feat/generated-functions
eduardoboucas 35fcc79
fix: add guard
eduardoboucas b0abce0
refactor: change directory computation
eduardoboucas dd189fc
chore: add comments
eduardoboucas 8029956
fix: use function `srcPath`
eduardoboucas 81558e5
Merge branch 'main' into feat/generated-functions
eduardoboucas 14518df
Merge branch 'main' into feat/generated-functions
eduardoboucas cbf1ada
refactor: fix comment typo
ndhoule 03f3b3e
Merge branch 'main' into feat/generated-functions
ndhoule 6841961
Merge branch 'main' into feat/generated-functions
ndhoule File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor: change directory computation
- Loading branch information
commit b0abce02f7e5fac7cea670d619a6364e76a06b5e
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super happy with this. For some context,
directory
contains the top-level functions directory where this specific function is found (not the sub-directory where a function may live). For example, for bothnetlify/functions/foo/index.js
andnetlify/functions/bar.js
this value would benetlify/functions
.This value was
undefined
for any functions ingeneratedFunctions
, because those functions don't typically live inside any of the regular function directories. So for those cases the right value to use issrcDir
.I think this is in need of some refactoring though, because I'm not sure why we need to keep track of the parent functions directory and not just the directory where the function lives.
I'm keeping this as is for now, where we're just adding
srcDir
as a fallback, to minimise the impact of this change, and then we'll revisit when possible.