Skip to content

refactor: use geolocation from @netlify/dev-utils package #7414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 11, 2025
Merged

refactor: use geolocation from @netlify/dev-utils package #7414

merged 4 commits into from
Jul 11, 2025

Conversation

keanu-a
Copy link
Contributor

@keanu-a keanu-a commented Jul 11, 2025

🎉 Thanks for submitting a pull request! 🎉

Summary

Replaced geolocation types and variables with @netlify/dev-utils geolocation primitives

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@keanu-a keanu-a requested a review from a team as a code owner July 11, 2025 15:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 11, 2025 •
edited
Loading

📊 Benchmark results

Comparing with ea66dd2

  • Dependency count: 1,081 (no change)
  • Package size: 288 MB ⬇️ 0.00% decrease vs. ea66dd2
  • Number of ts-expect-error directives: 399 (no change)

@keanu-a keanu-a changed the title Imported Geolocation from @netlify/dev-utils package chore: Geolocation from @netlify/dev-utils package Jul 11, 2025
serhalp
serhalp reviewed Jul 11, 2025
View reviewed changes
Copy link
Member

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor suggestions!

serhalp
serhalp approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

naming nitpick: might wanna call this one a refactor: and use a (present tense) verb to describe what's changing, e.g. "replace duplicated geolocation..." or "use geolocation from..."

@keanu-a keanu-a changed the title chore: Geolocation from @netlify/dev-utils package refactor: use geolocation from @netlify/dev-utils package Jul 11, 2025
@keanu-a keanu-a merged commit bcbcdcc into main Jul 11, 2025
67 of 68 checks passed
@keanu-a keanu-a deleted the keanu-a/use-geolocation-primitives branch July 11, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhalp serhalp serhalp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keanu-a @serhalp
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy