Skip to content

refactor: use useshouldbase64encode from @netlify/dev-utils #7445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

keanu-a
Copy link
Contributor

@keanu-a keanu-a commented Jul 21, 2025

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #EX-321

Refactored usages of shouldBase64Encode in cli to @netlify/dev-utils. Removed duplicated code.


Ref: https://github.com/netlify/primitives/blob/main/packages/dev-utils/src/lib/base64.ts#L12

Copy link

github-actions bot commented Jul 21, 2025

📊 Benchmark results

Comparing with ed3fa72

  • Dependency count: 1,081 (no change)
  • Package size: 288 MB (no change)
  • Number of ts-expect-error directives: 399 (no change)

@keanu-a keanu-a marked this pull request as ready for review July 21, 2025 19:12
@keanu-a keanu-a requested a review from a team as a code owner July 21, 2025 19:12
@keanu-a keanu-a merged commit 26b6d3d into main Jul 21, 2025
86 of 89 checks passed
@keanu-a keanu-a deleted the keanualoua/ex-348-use-useshouldbase64encode-from-netlifydev-utils branch July 21, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy