fix(next-auth): force session.update() to trigger session update
#11024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling session.update() without data, data will be undefined. If data is undefined, then req is undefined and in fetchData when req.body is not defined, the method will not be set to POST nor will the csrf token be included. I think that is why when you call session.update(), it doesn't actually trigger an update and the only way to get it to trigger an update is to call the function with data.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@chriseling is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11024 +/- ##
=======================================
Coverage 38.74% 38.74%
=======================================
Files 176 176
Lines 27887 27885 -2
Branches 1217 1223 +6
=======================================
Hits 10804 10804
+ Misses 17083 17081 -2 ☔ View full report in Codecov by Sentry. |
session.update() to trigger session update
|
It looks like this issue did not receive any activity for 60 days. It will be closed in 7 days if no further activity occurs. If you think your issue is still relevant, commenting will keep it open. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling session.update() without data, data will be undefined. If data is undefined, then req is undefined and in fetchData when req.body is not defined, the method will not be set to POST nor will the csrf token be included. I think that is why when you call session.update(), it doesn't actually trigger an update and the only way to get it to trigger an update is to call the function with data. Maybe this is by design, but it was confusing as I would expect session.update() to trigger a session update even without providing data (in the case where session data or user data has changed elsewhere)
☕️ Reasoning
🧢 Checklist
🎫 Affected issues
📌 Resources