QUIC: silence unknown/reserved transport param "info" messages. #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pluknet
reviewed
Apr 16, 2025
There was a problem hiding this comment.
Usually we use the following word form when describing such log level changes:
"lowered log level for .."
So it might looks as:
QUIC: lowered log level for unsupported transport parameters.
The patch itself looks good.
It goes in line with what's described in RFC 9000, 7.4.2 for unsupported parameters:
An endpoint MUST ignore transport parameters that it does not support
OK. Leaving just one line now. |
pluknet
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ngctp2, the following messages are usually logged:
These are grease bit (RFC 9287) and version negotiation (draft-ietf-quic-version-negotiation-13). The latter was changed to 0x11 in newer ngtcp2 code though.