Skip to content

fix: Change image for dark and light themes #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2023
Merged

fix: Change image for dark and light themes #16

merged 2 commits into from
Oct 27, 2023

Conversation

supunsathsara
Copy link
Member

@supunsathsara supunsathsara commented Oct 27, 2023 •
edited
Loading

Pull Request

Description

Implemented dynamic theming for the Logo component.

📌Changes Made

  • Updated the existing Logo component to change image for dark and light themes.
  • Added the NIBMCS light-theme logo.
  • Replaced static logo usage with the updated Logo component in the navbar and homepage.

Related Issue(s)

Closes #8

Checklist

Before submitting this pull request, please ensure the following:

  • I have read and followed the project's contributing guidelines.
  • My code follows the project's coding style and conventions.
  • My commits follow the project's commit message guidelines.
  • I have reviewed my changes to ensure they are complete and accurate.

Submission

Before submitting, please review your pull request to ensure it is complete and follows the provided checklist. Thank you for contributing!

@supunsathsara supunsathsara added enhancement New feature or request needs review labels Oct 27, 2023
@supunsathsara supunsathsara added this to the Version 1.0 milestone Oct 27, 2023
@supunsathsara supunsathsara self-assigned this Oct 27, 2023
@supunsathsara supunsathsara linked an issue Oct 27, 2023 that may be closed by this pull request
🐞 Bug: Change image for dark and light themes #8
Closed
@github-actions
Copy link

github-actions bot commented Oct 27, 2023 •
edited
Loading

This pull request is being automatically deployed to Netlify.

✅ Preview: https://pr-review-16--stirring-maamoul-21e9ba.netlify.app
🔖 Deployed version: 5d53b92

dileepadev
dileepadev approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@dileepadev dileepadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 works fine!

@dileepadev dileepadev merged commit 5d53b92 into dev Oct 27, 2023
@dileepadev dileepadev deleted the bugfix/8 branch October 27, 2023 17:27
@dileepadev dileepadev added the pull request Pull requests for the project label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dileepadev dileepadev dileepadev approved these changes

Assignees

@supunsathsara supunsathsara

Labels
enhancement New feature or request needs review pull request Pull requests for the project
Projects
NIBM CS Website
Status: Done
Milestone
Version 1.0
Development

Successfully merging this pull request may close these issues.

🐞 Bug: Change image for dark and light themes
2 participants
@supunsathsara @dileepadev
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy