fffpy.c: fix build failure with gcc 14. #568
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As initially reported in [Debian bug #1075317], nipy fails to build
from source with the following error since introduction of gcc 14, and
the promotion of several warnings as errors:
../lib/fff_python_wrapper/fffpy.c:17:3: error: returning ‘void *’ from a function with return type ‘IMP_OUT’ {aka ‘int’} makes integer from pointer without a cast [-Wint-conversion]
17 | import_array();
| ^~~~~~~~~~~~
This looks to be related to the logic revolving around setting the
type of IMP_OUT, as it does not know about the present import_array
macro "return type" in contemporary Numpy versions. Since Python 2 is
obsolete, this patch removes the Python major selector entirely to
replace by a hard wiring of the IMP_OUT type.
This may not be 100% suitable to everyone, but the time of
introduction of the void* return type to the import_array macro in
Numpy is unclear.
[Debian bug #1075317]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1075317
Signed-off-by: Étienne Mollier <emollier@debian.org>
|
Included in #565. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #568 +/- ##
=======================================
Coverage 84.61% 84.61%
=======================================
Files 293 293
Lines 27479 27479
Branches 3362 3362
=======================================
Hits 23252 23252
Misses 3273 3273
Partials 954 954 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As initially reported in Debian bug #1075317, nipy fails to build from source with the following error since introduction of gcc 14, and the promotion of several warnings as errors:
This looks to be related to the logic revolving around setting the type of IMP_OUT, as it does not know about the present import_array macro "return type" in contemporary Numpy versions. Since Python 2 is obsolete, this patch removes the Python major selector entirely to replace by a hard wiring of the IMP_OUT type.
This may not be 100% suitable to everyone, but the time of introduction of the void* return type to the import_array macro in Numpy is unclear.