Skip to content

doc: toggle all flavor selectors sticky on click #49526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 9, 2023
Merged

doc: toggle all flavor selectors sticky on click #49526

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bcb1e61
doc: toggle all flavor selectors sticky on click
eldoy Sep 7, 2023
61d6008
Update doc/api_assets/api.js
eldoy Sep 7, 2023
3e91b7c
fix initial setup of stored state
eldoy Sep 7, 2023
7922161
use localStorage instead of sessionStorage
eldoy Sep 7, 2023
6ac5fc2
optimize check in loop
eldoy Sep 7, 2023
95e6ae6
remove empty local storage
eldoy Sep 7, 2023
3e7d654
Merge branch 'main' into doc/toggle-all-selectors
eldoy Sep 8, 2023
ad92cfc
rename select to toggle
eldoy Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update doc/api_assets/api.js 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@eldoy @aduh95
eldoy and aduh95 authored Sep 7, 2023
commit 61d60081fc8b440b38542534c61f6c582c5a7ac8
8 changes: 2 additions & 6 deletions doc/api_assets/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,14 +144,10 @@

flavorSelectors.forEach((selector) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
flavorSelectors.forEach((selector) => {
flavorToggles.forEach((toggle) => {

selector.checked = flavorSetting !== vCommonJS;
selector.addEventListener('click', (e) => {
selector.addEventListener('change', (e) => {
const checked = e.target.checked;

if (checked) {
sessionStorage.removeItem(kFlavorPreference);
} else {
sessionStorage.setItem(kFlavorPreference, vCommonJS);
}
sessionStorage.setItem(kFlavorPreference, checked);

flavorSelectors.forEach((el) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
flavorSelectors.forEach((el) => {
flavorToggles.forEach((el) => {

el.checked = checked;
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy