Skip to content

build: bump minimum Clang version to 19 #59048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2025
Merged

build: bump minimum Clang version to 19 #59048

merged 1 commit into from
Aug 2, 2025
+56 −12

Conversation

targos
Copy link
Member

@targos targos commented Jul 13, 2025

This is now required by V8.

Refs: nodejs/node-v8#302

@targos targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 13, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. labels Jul 13, 2025
@targos
Copy link
Member Author

targos commented Jul 13, 2025

I checked Visual Studio 2022 on my computer and it has Clang 19.1.5.
With #58069, Xcode will have LLVM 19.1.4.

@targos
Copy link
Member Author

targos commented Jul 13, 2025

/cc @nodejs/build @nodejs/tsc

@targos targos added the blocked PRs that are blocked by other issues or PRs. label Jul 13, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 13, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.44%. Comparing base (751203d) to head (4aca101).
⚠️ Report is 27 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #59048      +/-   ##
==========================================
- Coverage   89.98%   89.44%   -0.54%     
==========================================
  Files         649      649              
  Lines      192180   192178       -2     
  Branches    37655    37367     -288     
==========================================
- Hits       172934   171898    -1036     
- Misses      11866    12824     +958     
- Partials     7380     7456      +76

see 103 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

richardlau
richardlau reviewed Jul 14, 2025
View reviewed changes
mcollina
mcollina approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@targos targos mentioned this pull request Jul 22, 2025
Open
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68365/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68366/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68367/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68368/

@targos targos added commit-queue Add this label to land a pull request using GitHub Actions. and removed blocked PRs that are blocked by other issues or PRs. labels Aug 2, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 2, 2025
@nodejs-github-bot nodejs-github-bot merged commit 8a87ba0 into nodejs:main Aug 2, 2025
60 of 61 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 8a87ba0

meteorqz6 pushed a commit to meteorqz6/node that referenced this pull request Aug 2, 2025
@targos @meteorqz6
build: bump minimum Clang version to 19
1f87bbf 
This is now required by V8.

Refs: nodejs/node-v8#302
PR-URL: nodejs#59048
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@legendecas
Copy link
Member

legendecas commented Aug 4, 2025 •
edited
Loading

@targos the latest clang version on macOS with Xcode (latest 16.4) is still on v17. Does this change mean that the current latest macOS/Xcode toolchain is out of support? https://en.wikipedia.org/wiki/Xcode#Xcode_15.0_-_16.x_(since_visionOS_support)_2

(Even with Xcode for macOS 26, the clang version is still 17)

/node $ ./configure
Node.js configure: Found Python 3.13.5...
WARNING: C++ compiler (CXX=c++, 17.0.0) too old, need g++ 12.2.0 or clang++ 19.1.0
WARNING: warnings were emitted in the configure phase

@legendecas
Copy link
Member

https://github.com/nodejs/node/blob/main/BUILDING.md#macos-prerequisites needs to be updated (though I think no available Xcode version comes with clang 19 for now).

@targos
Copy link
Member Author

targos commented Aug 4, 2025

the latest clang version on macOS with Xcode (latest 16.4) is still on v17

This is a "lie" from Apple. You can see the mapping from Xcode to true LLVM version here: https://en.wikipedia.org/wiki/Xcode#Xcode_15.0_-_16.x_(since_visionOS_support)_2
Xcode 16.3 contains LLVM 19.1.4 and is advertised as 17.0.0.

@targos
Copy link
Member Author

targos commented Aug 4, 2025

I guess we need to add a special case in the configure script to detect Apple Clang and compare with 17.0.0 on it.

@targos targos deleted the clang-19 branch August 4, 2025 16:06
@legendecas
Copy link
Member

Yeah, LLVM is v19

@targos
Copy link
Member Author

targos commented Aug 5, 2025

#59358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@richardlau richardlau richardlau approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@targos @nodejs-github-bot @legendecas @mcollina @jasnell @lpinca @anonrig @richardlau @RafaelGSS @marco-ippolito
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy