refactor: release check and version without minor

nodejs · canerakdas · May 20, 2025 · May 20, 2025 · May 20, 2025 · May 20, 2025
commit 924c640632ca8403fdc884ef92b5185dc258d169
diff --git a/apps/site/components/withSimplifiedDownload.tsx b/apps/site/components/withSimplifiedDownload.tsx
@@ -18,26 +18,31 @@ type WithSimplifiedDownloadProps = {
 const WithSimplifiedDownload: FC<WithSimplifiedDownloadProps> = async ({
   children: Component,
 }) => {
+  const { pathname } = getClientContext();
   const releaseData = await getReleaseData();
 
-  const { pathname } = getClientContext();
-  const major = pathname.split('/').pop();
-  const release = releaseData.find(
-    release =>
-      release.major === Number(major) ||
-      (release.isLts === true && major === 'simplified')
+  const version = pathname.split('/').pop();
+  const matchingRelease = releaseData.find(
+    ({ major, codename, isLts }) =>
+      major === Number(version) ||
+      codename === version ||
+      (isLts === true && version === 'simplified')
   );
 
-  const { binaries, installers, minors } = getDownloadTable(release!);
+  if (matchingRelease !== undefined) {
+    const { binaries, installers, minors } = getDownloadTable(matchingRelease);
 
-  return (
-    <Component
-      version={release?.versionWithPrefix || ''}
-      binaries={binaries}
-      installers={installers}
-      minors={minors}
-    />
-  );
+    return (
+      <Component
+        version={matchingRelease.versionWithPrefix}
+        binaries={binaries}
+        installers={installers}
+        minors={minors}
+      />
+    );
+  }
+
+  return null;
 };
 
 export default WithSimplifiedDownload;
diff --git a/apps/site/pages/en/download/simplified.mdx b/apps/site/pages/en/download/simplified.mdx
@@ -56,31 +56,36 @@ Learn more about [Node.js releases](/about/previous-releases), including the rel
   )}
 </WithSimplifiedDownload>
 
-## Other versions
-
 <WithSimplifiedDownload>
   {({ minors }) =>
-    minors.map(([binaries, installers,version]) => (
-      <details key={version}>
-        <summary><h3>Node.js® {version}</h3></summary>
-       <div>
-        <h4>Binary Downloads</h4>
-        <SimplifiedDownloadTable source={binaries} />
+    minors.length > 0 && (
+      <>
+        <h2>Other versions</h2>
+        {minors.map(([binaries, installers, version]) => (
+          <details key={version}>
+            <summary>
+              <h3>Node.js® {version}</h3>
+            </summary>
+            <div>
+              <h4>Binary Downloads</h4>
+              <SimplifiedDownloadTable source={binaries} />
 
-        <h4>Installer Packages</h4>
-        <SimplifiedDownloadTable source={installers} />
+              <h4>Installer Packages</h4>
+              <SimplifiedDownloadTable source={installers} />
 
-        <p>
-          Download a signed{' '}
-          <LinkWithArrow
-            href={`https://nodejs.org/dist/${version}/node-${version}.tar.gz`}
-          >
-            Node.js {version} source
-          </LinkWithArrow>{' '}
-          tarball.
-        </p>
-       </div>
-      </details>
-    ))}
+              <p>
+                Download a signed{' '}
+                <LinkWithArrow
+                  href={`https://nodejs.org/dist/${version}/node-${version}.tar.gz`}
+                >
+                  Node.js {version} source
+                </LinkWithArrow>{' '}
+                tarball.
+              </p>
+            </div>
+          </details>
+        ))}
+      </>
+    )}
 
 </WithSimplifiedDownload>