Skip to content

chore: splits out smoke-tests from publish-dryrun tests #8069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 29, 2025
Merged

chore: splits out smoke-tests from publish-dryrun tests #8069

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
abfbc75
fix smokes
reggi Jan 28, 2025
fab233d
fix run
reggi Jan 28, 2025
4ab57e5
undo package changes
reggi Jan 28, 2025
e35c62b
use hbs template
reggi Jan 28, 2025
9d4a123
chore: run smoke tests and publish dryrun on pr
reggi Jan 28, 2025
ade331d
removes matrix, and publish dry-run
reggi Jan 28, 2025
f5d401a
fix script put back matrix for release only
reggi Jan 28, 2025
cbc895f
fix names
reggi Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use hbs template
  • Loading branch information
@reggi
reggi committed Jan 28, 2025
commit e35c62b5b465ab1f211a6c0f144266994afe743b
37 changes: 18 additions & 19 deletions .github/workflows/ci-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,13 +144,13 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}
conclusion: ${{ job.status }}
check_id: ${{ steps.create-check.outputs.check-id }}

smoke-tests:
# This cant be tested on Windows because our node_modules directory
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
name: Smoke Tests - ${{ matrix.platform.name }} - ${{ matrix.node-version }}
# This cant be tested on Windows because our node_modules directory
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
name: Smoke Publish - ${{ matrix.platform.name }} - ${{ matrix.node-version }}
if: github.repository_owner == 'npm'
strategy:
fail-fast: false
Expand All @@ -160,10 +160,9 @@ jobs:
os: ubuntu-latest
shell: bash
node-version:
- 18.17.0
- 18.x
- 20.5.0
- 20.17.0
- 20.x
- 22.9.0
- 22.x
runs-on: ${{ matrix.platform.os }}
defaults:
Expand All @@ -183,7 +182,7 @@ jobs:
if: ${{ inputs.check-sha }}
uses: ./.github/actions/create-check
with:
name: "Publish dry-run - ${{ matrix.platform.name }} - ${{ matrix.node-version }}"
name: "Smoke Publish - ${{ matrix.platform.name }} - ${{ matrix.node-version }}"
token: ${{ secrets.GITHUB_TOKEN }}
sha: ${{ inputs.check-sha }}
- name: Setup Node
Expand All @@ -197,7 +196,7 @@ jobs:
run: node scripts/git-dirty.js
- name: Reset Deps
run: node scripts/resetdeps.js
- name: Smoke Publish
- name: Smoke Tests
run: ./scripts/smoke-tests.sh
- name: Conclude Check
uses: LouisBrunner/checks-action@v1.6.0
Expand All @@ -206,13 +205,13 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}
conclusion: ${{ job.status }}
check_id: ${{ steps.create-check.outputs.check-id }}

publish-dryrun:
# This cant be tested on Windows because our node_modules directory
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
name: Publish dry-run - ${{ matrix.platform.name }} - ${{ matrix.node-version }}
# This cant be tested on Windows because our node_modules directory
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
name: Smoke Publish - ${{ matrix.platform.name }} - ${{ matrix.node-version }}
if: github.repository_owner == 'npm'
strategy:
fail-fast: false
Expand Down Expand Up @@ -244,7 +243,7 @@ jobs:
if: ${{ inputs.check-sha }}
uses: ./.github/actions/create-check
with:
name: "Publish dry-run - ${{ matrix.platform.name }} - ${{ matrix.node-version }}"
name: "Smoke Publish - ${{ matrix.platform.name }} - ${{ matrix.node-version }}"
token: ${{ secrets.GITHUB_TOKEN }}
sha: ${{ inputs.check-sha }}
- name: Setup Node
Expand All @@ -258,7 +257,7 @@ jobs:
run: node scripts/git-dirty.js
- name: Reset Deps
run: node scripts/resetdeps.js
- name: Smoke Publish
- name: Publish Dry-Run
run: ./scripts/publish-dryrun.sh
- name: Conclude Check
uses: LouisBrunner/checks-action@v1.6.0
Expand Down
66 changes: 44 additions & 22 deletions scripts/template-oss/ci-release-yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,45 @@
{{> ciReleaseYml }}
{{> ciReleaseYml }}

smoke-publish:
# This cant be tested on Windows because our node_modules directory
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
{{> jobMatrixYml
jobName="Smoke Publish"
jobCheckout=(obj ref="${{ inputs.ref }}")
jobCreateCheck=(obj sha="${{ inputs.check-sha }}")
windowsCI=false
macCI=false
}}
- name: Smoke Publish
run: ./scripts/smoke-publish-test.sh
- name: Conclude Check
uses: LouisBrunner/checks-action@v1.6.0
if: steps.create-check.outputs.check-id && always()
with:
token: $\{{ secrets.GITHUB_TOKEN }}
conclusion: $\{{ job.status }}
check_id: $\{{ steps.create-check.outputs.check-id }}
smoke-tests:
# This cant be tested on Windows because our node_modules directory
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
{{> jobMatrixYml
jobName="Smoke Publish"
jobCheckout=(obj ref="${{ inputs.ref }}")
jobCreateCheck=(obj sha="${{ inputs.check-sha }}")
windowsCI=false
macCI=false
}}
- name: Smoke Tests
run: ./scripts/smoke-tests.sh
- name: Conclude Check
uses: LouisBrunner/checks-action@v1.6.0
if: steps.create-check.outputs.check-id && always()
with:
token: $\{{ secrets.GITHUB_TOKEN }}
conclusion: $\{{ job.status }}
check_id: $\{{ steps.create-check.outputs.check-id }}

publish-dryrun:
# This cant be tested on Windows because our node_modules directory
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
{{> jobMatrixYml
jobName="Smoke Publish"
jobCheckout=(obj ref="${{ inputs.ref }}")
jobCreateCheck=(obj sha="${{ inputs.check-sha }}")
windowsCI=false
macCI=false
}}
- name: Publish Dry-Run
run: ./scripts/publish-dryrun.sh
- name: Conclude Check
uses: LouisBrunner/checks-action@v1.6.0
if: steps.create-check.outputs.check-id && always()
with:
token: $\{{ secrets.GITHUB_TOKEN }}
conclusion: $\{{ job.status }}
check_id: $\{{ steps.create-check.outputs.check-id }}
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy