Skip to content

RFC: Add staging workflow for CI and human interoperability #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

RFC: Add staging workflow for CI and human interoperability #92

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36d43f9
rfc: staging workflow for CI and human interoperability
djsauble Nov 21, 2019
15b6a18
Update accepted/0000-staged-packages.md
darcyclarke Mar 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update accepted/0000-staged-packages.md 
Co-Authored-By: Dominykas Blyžė <hello@dominykas.com>
  • Loading branch information
@darcyclarke @dominykas
darcyclarke and dominykas authored Mar 25, 2020
commit 15b6a18dd8615a958a6f8051a7737b08a93c20e9
2 changes: 1 addition & 1 deletion accepted/0000-staged-packages.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ which we and our community are both familiar.
published to staging.
* A new `--stage` flag for the `npm install` command that allows a package to be
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth clarifying here that semver rules still apply (i.e. the staged version, if any, will only be installed if it matches the specifier in package.json)

Copy link

@wesleytodd wesleytodd Feb 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I am reading this, I feel like one other addition should be made here. Install --stage would only work with a single package and a specific version. Example:

Good:

$ npm i --stage foo@1.0.0

Bad:

$ npm i --stage
$ npm i --stage foo
$ npm i --stage foo@^1.0.0
$ npm i --stage foo@latest

Again with the goal that installing from the stage be hard and a very explicit action.

EDIT: read from top to bottom and I see @isaacs has some other ideas. I will have time later today to read them, but it looks like this comment might have been premature.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would npm i --stage foo@1.0.0 do to package.json? A use case for this feature would be to stage an update from a monorepo then post a PR against something outside the monorepo to have Travis-CI test it using the staged update before I promoting.

installed from staging.
* A new `--stage` flag for the `npm view` command that allows us to retrive data
* A new `--stage` flag for the `npm view` command that allows us to retrieve data
for staged packages.
* A new `npm promote` command that allows a user to promote a staged package.
* The ability to set a `staging` scope on auth tokens so we can grant read or
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy