Instead of interning all these, can you use PyObject_GetOptionalAttrString?

Hi @eric-wieser , Thank You for the feedback.

the interned version would help us get faster as we would be saving time, compare to the PyObject_GetOptionalAttrString which will be initialising the new string every time.

This still isn't right; if this returns 0, then you need to return the date-only version. Continuing with tmp not set as you currently do is a bug.

Perhaps it would be best to write some tests before going further; to be able to see the impact here, you need to make some custom objects, which:

• Throw errors when .hour is accessed
• Succeed the first time that .hour is accessed, but fails the second time.

hmm, what i thought is PyObject_HasAttrString will be good to check for the 0 cases ?

if (!PyObject_HasAttrString(obj, "hour") || !PyObject_HasAttrString(obj, "minute") || !PyObject_HasAttrString(obj, "second") || !PyObject_HasAttrString(obj, "microsecond")) { /* The best unit for date is 'D' */ if (out_bestunit != NULL) { *out_bestunit = NPY_FR_D; } return 0; }

-1 we are handling with : if (PyObject_GetOptionalAttr(obj, npy_interned_str.hour, &tmp) == -1)

It is possible for HasAttr to return true, but for the attribute to not be present when you ask a second time:

class OhNo:
    _count = 0
    @property
    def date(self):
        self._count += 1
        if self._count % 2 == 0:
            raise AttributeError
        else:
            return "today"
            
o = OhNo()
print(hasattr(o, "date")) # prints True
print(o.date) # fails