MAINT: Improve type checking in power fast paths

numpy · seberg · Jan 7, 2025 · Dec 4, 2024 · Dec 4, 2024 · Dec 4, 2024
commit 21c12a679e6c94e85d5feeff7d6abaa86c5b05cd
diff --git a/numpy/_core/src/multiarray/number.c b/numpy/_core/src/multiarray/number.c
@@ -331,15 +331,6 @@ array_inplace_matrix_multiply(PyArrayObject *self, PyObject *other)
 static int
 fast_scalar_power(PyObject *o1, PyObject *o2, int inplace, PyObject **result)
 {
-    if (!PyArray_Check(o1)) {
-        return -1;
-    }
-
-    PyArrayObject *a1 = (PyArrayObject *)o1;
-    if (PyArray_ISOBJECT(a1)) {
-        return 1;
-    }
-
     PyObject *fastop = NULL;
     if (PyLong_CheckExact(o2)) {
         int overflow = 0;
@@ -371,6 +362,11 @@ fast_scalar_power(PyObject *o1, PyObject *o2, int inplace, PyObject **result)
         return 1;
     }
 
+    PyArrayObject *a1 = (PyArrayObject *)o1;
+    if (PyArray_ISOBJECT(a1)) {
+        return 1;
+    }
+
     if (inplace || can_elide_temp_unary(a1)) {
         *result = PyArray_GenericInplaceUnaryFunction(a1, fastop);
     }