-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
BUILD: move to manylinux_2_28 wheel builds #28436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also remove unused tool script
Should I add a link to the compliance table to the release note? |
The free-threading wheel builds are failing with numpy/numpy/random/_examples/cython/meson.build Lines 45 to 53 in 7f0ebda
|
Maybe something connected to mesonbuild/meson#14284 ? |
I'd hope not, because that bug shouldn't be present in any release. The build output seems to show
That sounds useful, more people should know about that table and it is relevant here. |
Super weird that it only seems to matter on the free-threaded builds. Let me know if you want me to look closer at this. It's hard to compare with the tests on the most recent wheel build because it uses pytest-xdist. It's possible the test was being skipped before, though. |
It is only happening in the manylinux_2_28 builds. I wonder if the compiler is subtly broken there?
@ngoldbaum how can I say no to such an offer? |
with #28415 merged, the version of manylinux_2_28 will be bumped. It uses a gcc 14 toolchain instead of gcc 13. It might be worth rebasing/merging main to see if this helps with the failing test. |
In g++ version 14 I see the symbol defined in libstc++ (and only there). Perhaps is was elsewhere before?
|
That seems to have fixed it. In it goes. |
Unfortunately, It's not fixed. The last commit did not trigger the wheel builder workflow. |
As discussed in the mailing list, move to manylinux_2_28 wheels.
Also remove unused tool script