MNT: add support for 3.14.0b1 #28928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorenham
reviewed
May 8, 2025
charris
reviewed
May 8, 2025
|
The TSAN failure looks legitimate, but we can ignore it for now. |
|
@nascheme - would you mind kicking off a new build of the CPython sanity docker image? Looks like it's stuck on alpha 7. |
|
Thanks Nathan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes our use of CPython internals in favor of the new API added for this purpose in 3.14. See python/cpython#133164.
I also dropped support for 3.14.0a7 since that is known to be broken without using CPython internals. I could also not add the explicit error case, but it seemed better to break known-broken configurations we don't want to support. Happy to do it either way if anyone disagrees.
There's a new deprecation warning coming from the
structmodule. I ignored it for now and opened an issue (#28926).