Skip to content

BUG: add bounds-checking to in-place string multiply #29060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 27, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
MNT: handle overflow in one more spot
  • Loading branch information
ngoldbaum committed May 27, 2025
commit 24643be593de91ab68a959048a30256bcee4b5a4
6 changes: 3 additions & 3 deletions numpy/_core/src/umath/stringdtype_ufuncs.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1748,9 +1748,9 @@ center_ljust_rjust_strided_loop(PyArrayMethod_Context *context,
width - num_codepoints);
newsize += s1.size;

if (overflowed) {
npy_gil_error(PyExc_MemoryError,
"Failed to allocate string in %s", ufunc_name);
if (overflowed || newsize > PY_SSIZE_T_MAX) {
npy_gil_error(PyExc_OverflowError,
"Overflow encountered in %s", ufunc_name);
goto fail;
}

Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy