PERF: Make NpzFile member existence checks constant-time #29098
Merged
+29
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
approved these changes
May 31, 2025
| else: | ||
| raise KeyError(f"{key} is not a file in the archive") | ||
| with self.zip.open(key) as bytes: |
There was a problem hiding this comment.
Thanks for making this a context manager use also. Might have omitted the else: myself here, but I think that is just personal taste. No need for new tests here I would agree.
|
Can be backported, I think (but also no particularly big need). |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
May 31, 2025
…s constant time (numpy#29098) Use dict instead of list to convert the passed key to the name used in the archive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use dict instead of list to convert the passed key to the name used in the archive.
Closes #29081