DEP: rename hanning windows to hann window while keeping compatibility #29123
Conversation
There was a problem hiding this comment.
Thanks, but needs a test as everything does.
It may make sense to go the SciPy route, and just add hann first and not document hanning much, and start deprecation later (the advantage is that libraries can switch to hann directly and don't need conditionals). Although 14k hits on github isn't that much. I honestly don't have a strong opinion either way.
(For the most part, I think scipy.signal.windows is the right place, but these have been around forever and we should keep some... Would be nice to link out to there, but not this PR.)
| However, the term Hanning function is also conventionally used, derived | ||
| from the paper in which the term hanning a signal was used to mean applying | ||
| the Hann window to it. It is distinct from the similarly-named Hamming | ||
| function, named after Richard Hamming. |
There was a problem hiding this comment.
It's just two sentences and not sure what the "limit" is, but please don't just copy from wikipedia (wikipedia does require attribution!).
Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
| The Hann window was named for Julius von Hann, an Austrian meteorologist. | ||
| It is also known as the Hanning window, which is a misnomer. | ||
| However, the term Hanning function is also conventionally used, derived | ||
| from the paper in which the term hanning a signal was used to mean applying | ||
| the Hann window to it. It is distinct from the similarly-named Hamming | ||
| function, named after Richard Hamming. |
There was a problem hiding this comment.
| The Hann window was named for Julius von Hann, an Austrian meteorologist. | |
| It is also known as the Hanning window, which is a misnomer. | |
| However, the term Hanning function is also conventionally used, derived | |
| from the paper in which the term hanning a signal was used to mean applying | |
| the Hann window to it. It is distinct from the similarly-named Hamming | |
| function, named after Richard Hamming. | |
| The Hann window was named for Julius von Hann, an Austrian meteorologist. | |
| It is often mistakenly called the "Hanning" window. This confusion likely | |
| arises from its similarity to the Hamming window, named after Richard Hamming. |
Would this be OK ?
This PR has already been a little personal challenge and I don't know how you maintainers work in this repo. I'm not sure to understand everything here. Just let me know clearly if there is any more to do on my side. (I will not be available during upcoming 2 weeks though). |
Close #17303