Skip to content

TYP: add missing numpy.lib exports #29145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2025
Merged

TYP: add missing numpy.lib exports #29145

merged 1 commit into from
Jun 8, 2025

Conversation

jorenham
Copy link
Member

@jorenham jorenham commented Jun 8, 2025

Spotted by stubtest in numtype.

@jorenham jorenham added 09 - Backport-Candidate PRs tagged should be backported 41 - Static typing labels Jun 8, 2025
@jorenham jorenham force-pushed the typing/lib.__all__ branch 2 times, most recently from c016a47 to 222ee84 Compare June 8, 2025 01:02
@jorenham jorenham force-pushed the typing/lib.__all__ branch from 222ee84 to 7bf8570 Compare June 8, 2025 01:03
rgommers
rgommers approved these changes Jun 8, 2025
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That all LGTM. A bit unfortunate that stubtest seems to need info on explicitly private namespaces though, but it can't hurt so I'll just go ahead and merge this.

The format entry was indeed missing in __all__, it's already present in __init__.py.

@rgommers rgommers merged commit 0b6a990 into numpy:main Jun 8, 2025
76 checks passed
@rgommers rgommers added this to the 2.4.0 release milestone Jun 8, 2025
@jorenham jorenham deleted the typing/lib.__all__ branch June 8, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
09 - Backport-Candidate PRs tagged should be backported 41 - Static typing
Projects
None yet
Milestone
2.4.0 release
Development

Successfully merging this pull request may close these issues.
2 participants
@jorenham @rgommers
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy