DOC: vectorize with signature doesn't pre-call function #29335
Conversation
|
Could someone please take a look? |
| @@ -2332,7 +2332,7 @@ class vectorize: | |||
|
|
|||
| cache : bool, optional | |||
| If `True`, then cache the first function call that determines the number | |||
| of outputs if `otypes` is not provided. | |||
| of outputs if `otypes` and `signature` are not provided. | |||
There was a problem hiding this comment.
Where in the code does signature come into play? I took a cursory look and it seemed only otypes is involved in the cache. In any case, perhaps:
If True, then cache the number of outputs from a function call in order to speed up subsequent calls. Effective only if otypes is not provided (or Effective only if neither otypes nor signature are provided).
There was a problem hiding this comment.
Here:
numpy/numpy/lib/_function_base_impl.py
Line 2622 in d621a31
The cache-related logic isn't even reached if signature is provided.
About the wording, could we tackle that separately?
There was a problem hiding this comment.
OK, so the change seems correct.
could we tackle that separately?
@rkern wrote the original docstring, maybe he has an opinion.
There was a problem hiding this comment.
I did? I don't really know any of the details now, at least; I don't really use vectorize and am unfamiliar with the caching functionality.
Aligns doc with the implementation