BUG: fix casting issue in center, ljust, rjust, and zfill #29369
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
approved these changes
Jul 14, 2025
There was a problem hiding this comment.
Func casting, but I think we said it may not be worthwhile to deal with such overflows on 32bits (indexing is also slightly sloppy with unsigned and nobody ever notices).
Negative values seem almost error worthy, but so long it is supported in the Python version, this seems good.
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Jul 22, 2025
charris
added a commit
that referenced
this pull request
Jul 22, 2025
BUG: fix casting issue in center, ljust, rjust, and zfill (#29369)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29359.
We were comparing signed and unsigned integers so any negative width wasn't being corrected.