-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
TYP: Type MaskedArray.__array_finalize__
and MaskedArray.__array_wrap__
#29483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MarcoGorelli
wants to merge
3
commits into
numpy:main
Choose a base branch
from
MarcoGorelli:typ-ma-array-wrap
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Jul 30, 2025
7b1044f
to
42b711c
Compare
42b711c
to
aabdd11
Compare
50 tasks
jorenham
reviewed
Jul 30, 2025
numpy/ma/core.pyi
Outdated
Comment on lines
524
to
530
def __array_wrap__( | ||
self, | ||
obj: ndarray[_ShapeT, _DTypeT], | ||
context: tuple[ufunc, tuple[Any, ...], int] | None = None, | ||
return_scalar: bool = False, | ||
/, | ||
) -> MaskedArray[_ShapeT, _DTypeT]: ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one isn't positional-only
Line 3144 in 46268ca
def __array_wrap__(self, obj, context=None, return_scalar=False): |
MarcoGorelli
commented
Jul 31, 2025
jorenham
approved these changes
Jul 31, 2025
Needs a rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last untyped method in
MaskedArray
😆 🥳